Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix showing deployment details callout on Cloud staging #116123

Merged
merged 1 commit into from
Oct 25, 2021
Merged

[Fleet] Fix showing deployment details callout on Cloud staging #116123

merged 1 commit into from
Oct 25, 2021

Conversation

joshdover
Copy link
Contributor

Summary

Fixes #116076

This adds support for an additional cname suffix required to support this UI on Cloud staging.

@joshdover joshdover added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 Feature:Unified Integrations Unified Integrations view feature labels Oct 25, 2021
@joshdover joshdover requested a review from a team as a code owner October 25, 2021 12:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

nchaulet
nchaulet approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joshdover joshdover enabled auto-merge (squash) October 25, 2021 14:01
kpollich
kpollich approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joshdover joshdover merged commit 504896d into elastic:master Oct 25, 2021
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 621.3KB 621.3KB +26.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2021
@joshdover @kibanamachine
[Fleet] Fix showing deployment details callout on Cloud staging (elas…
735dc91 
…tic#116123)
@kibanamachine kibanamachine mentioned this pull request Oct 25, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.16

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 25, 2021
@kibanamachine @joshdover
[Fleet] Fix showing deployment details callout on Cloud staging (#116123
d6cf4bf 
) (#116181)

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

@nchaulet nchaulet nchaulet approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Unified Integrations Unified Integrations view feature release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deployment details CTA missing from Cloud staging
5 participants
@joshdover @elasticmachine @kibanamachine @nchaulet @kpollich